Skip to content

CDPTKAN-988 Fix issue with node versions#2953

Merged
Tony Mckernan (tmckernan) merged 1 commit into
mainfrom
CDPTKAN-988-fix-node-version-issue
May 19, 2026
Merged

CDPTKAN-988 Fix issue with node versions#2953
Tony Mckernan (tmckernan) merged 1 commit into
mainfrom
CDPTKAN-988-fix-node-version-issue

Conversation

@tmckernan
Copy link
Copy Markdown
Contributor

@tmckernan Tony Mckernan (tmckernan) commented May 19, 2026

Fix issue building web docker image. When it has the wrong version of node.
https://app.circleci.com/pipelines/github/ministryofjustice/fb-editor/11206/workflows/52523c52-9143-4455-8818-4afcfa88a262

------
 > [24/26] RUN yarn install --production --check-files:
0.439 yarn install v1.22.22
0.518 [1/5] Validating package.json...
0.523 error fb_editor@0.1.0: The engine "node" is incompatible with this module. Expected version "^16.20.1". Got "24.14.1"
0.533 error Found incompatible module.
0.533 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
------

 4 warnings found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 47)
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 60)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 39)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 46)
Dockerfile:51
--------------------
  49 |     ARG RAILS_ENV=production
  50 |     
  51 | >>> RUN yarn install --production --check-files

@tmckernan Tony Mckernan (tmckernan) marked this pull request as ready for review May 19, 2026 12:49
@tmckernan Tony Mckernan (tmckernan) requested a review from a team as a code owner May 19, 2026 12:49
@tmckernan Tony Mckernan (tmckernan) merged commit e1e3b97 into main May 19, 2026
11 checks passed
@tmckernan Tony Mckernan (tmckernan) deleted the CDPTKAN-988-fix-node-version-issue branch May 19, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants